Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[channel] Params.id may be inconsistent with object properties #188

Open
matthiasgeihs opened this issue Sep 14, 2021 · 0 comments
Open
Labels
proposal This is not a worked out concept yet.

Comments

@matthiasgeihs
Copy link
Contributor

Location

channel/params.go

Problem

Params.id is derived from the other properties of Params and is used to identify an object instance. However, since most properties of Params are exported, we can change them without changing Params.id, hence, leaving the object in an inconsistent state. This caused problems before (e.g., #56) and can lead to security-relevant bugs.

Proposal

We remove property Params.id and always calculate the identifier on the fly.

@matthiasgeihs matthiasgeihs added the proposal This is not a worked out concept yet. label Sep 14, 2021
@ggwpez ggwpez mentioned this issue Nov 4, 2021
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
proposal This is not a worked out concept yet.
Projects
None yet
Development

No branches or pull requests

1 participant