Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reject incoming updates when the channel is in registering or later phases #178

Open
manoranjith opened this issue Sep 3, 2021 · 3 comments

Comments

@manoranjith
Copy link
Contributor

Context

Currently,

  1. For outgoing updates, updateGeneric calls machine.Update, which in turn checks if machine is in Acting phase

  2. For incoming updates, CheckUpdate is called, which in turn calls validTransition.

Problem

I think, this means an incoming update will be passed onto the user even when the channel is in registering or later phases. It will be upto the user of go-perun to check the phase and then reject this update.

Possible solution

In CheckUpdate, return error if phase of the registering or later phases.

@manoranjith
Copy link
Contributor Author

@matthiasgeihs

@manoranjith
Copy link
Contributor Author

@matthiasgeihs Do you think we should consider this for next release ?

@matthiasgeihs
Copy link
Contributor

Seems relevant, we should consider it, for the upcoming, or alternatively for the next release. Is there a way to add optional items to a release?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants