Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[misc] refactor launch API and tensor constructor #5666

Merged
merged 7 commits into from
Apr 29, 2024
Merged

[misc] refactor launch API and tensor constructor #5666

merged 7 commits into from
Apr 29, 2024

Conversation

ver217
Copy link
Member

@ver217 ver217 commented Apr 28, 2024

📌 Checklist before creating the PR

  • I have created an issue for this PR for traceability
  • The title follows the standard format: [doc/gemini/tensor/...]: A concise description
  • I have added relevant tags if possible for us to better distinguish different PRs
  • I have installed pre-commit: pip install pre-commit && pre-commit install

🚨 Issue number

Link this PR to your issue with words like fixed to automatically close the linked issue upon merge

e.g. fixed #1234, closed #1234, resolved #1234

📝 What does this PR do?

Summarize your work here.
if you have any plots/diagrams/screenshots/tables, please attach them here.

💥 Checklist before requesting a review

  • I have linked my PR to an issue (instruction)
  • My issue clearly describes the problem/feature/proposal, with diagrams/charts/table/code if possible
  • I have performed a self-review of my code
  • I have added thorough tests.
  • I have added docstrings for all the functions/methods I implemented

⭐️ Do you enjoy contributing to Colossal-AI?

  • 🌝 Yes, I do.
  • 🌚 No, I don't.

Tell us more if you don't enjoy contributing to Colossal-AI.

@ver217 ver217 added the API related to API changes label Apr 28, 2024
@ver217 ver217 requested a review from FrankLeeeee April 28, 2024 03:46
@ver217 ver217 requested a review from a team as a code owner April 28, 2024 03:46
@ver217 ver217 merged commit 7f8b166 into hpcaitech:main Apr 29, 2024
21 of 23 checks passed
@ver217 ver217 deleted the hotfix/misc branch April 29, 2024 02:40
wangbluo pushed a commit to wangbluo/ColossalAI that referenced this pull request May 7, 2024
@ver217 @pre-commit-ci @wangbluo
[misc] refactor launch API and tensor constructor (hpcaitech#5666)
72f2fcb 
* [misc] remove config arg from initialize

* [misc] remove old tensor contrusctor

* [plugin] add npu support for ddp

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* [devops] fix doc test ci

* [test] fix test launch

* [doc] update launch doc

---------

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FrankLeeeee FrankLeeeee FrankLeeeee approved these changes

Assignees
No one assigned
Labels
API related to API changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ver217 @FrankLeeeee