Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

POC on Gitbook search implementation #23

Open
3 tasks
amansinghbais opened this issue Jun 7, 2024 · 0 comments
Open
3 tasks

POC on Gitbook search implementation #23

amansinghbais opened this issue Jun 7, 2024 · 0 comments
Assignees
@Adameddy26
Labels
enhancement New feature or request release-1.0.0

Comments

@amansinghbais
Copy link
Contributor

What is the motivation for adding/enhancing this feature?

What are the acceptance criteria?

  • ...

Can you complete this feature request by yourself?

  • YES
  • NO

Additional information
@amansinghbais amansinghbais added the enhancement New feature or request label Jun 7, 2024
@amansinghbais amansinghbais self-assigned this Jun 7, 2024
@amansinghbais amansinghbais changed the title POC on github search implementation POC on Gitbook search implementation Jun 7, 2024
amansinghbais added a commit to amansinghbais/company that referenced this issue Jun 7, 2024
@amansinghbais
Implemented: gitbook search implementation in our app (hotwax#23)
a646ee8
@amansinghbais amansinghbais moved this from 📋 Backlog to 🏗 In progress in Digital Experience Platform Jun 7, 2024
@amansinghbais amansinghbais moved this from 🏗 In progress to 👀 In review in Digital Experience Platform Jun 12, 2024
amansinghbais added a commit to amansinghbais/company that referenced this issue Jun 12, 2024
@amansinghbais
Improved: entry in the env.example (hotwax#23)
dd3436b
amansinghbais added a commit to amansinghbais/company that referenced this issue Jun 13, 2024
@amansinghbais
Improved: positioning of the searchbar in lens search modal (hotwax#23)
f902dd5
amansinghbais added a commit to amansinghbais/company that referenced this issue Jun 14, 2024
@amansinghbais
Improrved: added entry for the gitbook api baseUrl, improved method n…
b912832 
…ame (hotwax#23)
amansinghbais added a commit to amansinghbais/company that referenced this issue Jun 14, 2024
@amansinghbais
Improved: added slots in icons, method name for loading (hotwax#23)
ad19a30
amansinghbais added a commit to amansinghbais/company that referenced this issue Jun 17, 2024
@amansinghbais
Improved: axios request intercept to avoid sending api_key in case of…
3643e6a 
… gitbook api calls (hotwax#23)
amansinghbais added a commit to amansinghbais/company that referenced this issue Jun 18, 2024
@amansinghbais
Implemented: logic to show gitbookSearch modal from dxp (hotwax#23)
174b885
amansinghbais added a commit to amansinghbais/company that referenced this issue Jun 18, 2024
@amansinghbais
Improved: logic for rendering gitbook search tab button (hotwax#23)
0b58762
amansinghbais added a commit to amansinghbais/company that referenced this issue Jun 19, 2024
@amansinghbais
Improved: logic to use oms-api for gitbook search (hotwax#23)
79d9c45
@amansinghbais amansinghbais mentioned this issue Jun 21, 2024
Merged
1 task
amansinghbais added a commit to amansinghbais/company that referenced this issue Jul 9, 2024
@amansinghbais
Improved: added entry in env for the gitbook credentials (hotwax#23)
97ebd99
amansinghbais added a commit to amansinghbais/company that referenced this issue Jul 9, 2024
@amansinghbais
Implemented: entry in translation for static text used in gitbook ser…
bdf83ae 
…ach modal in dxp-components (hotwax#23)
amansinghbais added a commit to amansinghbais/company that referenced this issue Jul 9, 2024
@amansinghbais
Improved: dependency versions for the dxp-components and oms-api (hot…
4fbe5cf 
…wax#23)
ravilodhi added a commit that referenced this issue Jul 10, 2024
@ravilodhi
Merge pull request #26 from amansinghbais/23-gitbook-modal
079ead6 
Implemented: logic to show gitbookSearch modal from dxp (#23)
@amansinghbais amansinghbais moved this from 👀 In review to ⏸️ Dev complete in Digital Experience Platform Jul 10, 2024
@amansinghbais amansinghbais removed their assignment Jul 15, 2024
@Adameddy26 Adameddy26 moved this from ⏸️ Dev complete to 🛠 In QA in Digital Experience Platform Aug 1, 2024
@Adameddy26 Adameddy26 self-assigned this Aug 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Adameddy26 Adameddy26

Labels
enhancement New feature or request release-1.0.0
Projects
Digital Experience Platform
Status: 🛠 In QA
Milestone
No milestone
Development

No branches or pull requests
2 participants
@amansinghbais @Adameddy26