Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ability to generate JSON Patches (RFC 6902) #156

Open
madhukar93 opened this issue May 6, 2021 · 2 comments · May be fixed by #282
Open

ability to generate JSON Patches (RFC 6902) #156

madhukar93 opened this issue May 6, 2021 · 2 comments · May be fixed by #282

Comments

@madhukar93
Copy link

Could dyff have a feature for creating json patches for the diffs based on something like jsondiff. Would be really useful for working with things like Kustomize and admission controllers.
@HeavyWombat
Copy link
Member

HeavyWombat commented May 6, 2021 •
edited
Loading

The predecessor of this tool had pretty much this feature. It was able to create YAML files with Spruce directives, which were effectively patches. We used it for a migration effort. It never found its way into dyff so far even though I had initially planned for it as #12, but it could be a nice addition.

@madhukar93
Copy link
Author

looks like go-diff does the heavy lifting? jsondiff does it's own thing, from a cursory look. I'll look for more implementations.

@bkeroack bkeroack linked a pull request Mar 1, 2023 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Implement patch generation, apply and tests bkeroack/dyff
2 participants
@HeavyWombat @madhukar93