Inconsistent behavior with delete polygon/element

[kcpevey]

PolyDrawTool

1. If you create a polygon, don't move the mouse after the closing double click, and press backspace key, it deletes the poly
2. If you create a polygon, move the mouse after the closing double click, and press backspace key, it doesn't delete the poly
3. If you click to select an existing polygon, don't move the mouse, press backspace, it doesn't delete the poly.
4. If you click to select an existing polygon, move the mouse, press backspace, it will delete the poly.

I've seen similar behavior with the Point tool except that the FIRST point that is selected for deletion seems to have a different behavior than the subsequent ones. I can go through writing all that up very verbosely if necessary.

[kcpevey]

Still seeing these issues. And I have one more to add:

5. If you double click to select an existing polygon (such that the vertices are visible), move the mouse, press backspace, it will NOT delete the poly. Very similar approach to 4, resulting in different behavior.

[philippjfr]

Thanks for these, since I'm working on the tools right now, I'll try to fix them all right away.

[philippjfr]

Okay just reviewed these issues after all my recent changes (which are not yet released).

If you create a polygon, don't move the mouse after the closing double click, and press backspace key, it deletes the poly

Already fixed.

If you create a polygon, move the mouse after the closing double click, and press backspace key, it doesn't delete the poly

This is still true.

If you click to select an existing polygon, don't move the mouse, press backspace, it doesn't delete the poly.

It does seem to do so now.

If you click to select an existing polygon, move the mouse, press backspace, it will delete the poly.

Still true.

If you double click to select an existing polygon (such that the vertices are visible), move the mouse, press backspace, it will NOT delete the poly. Very similar approach to 4, resulting in different behavior.

Presumably this is about the PolyEditTool? That is primarily about interacting with vertices but if you think it's more consistent for it to allow deleting whole polygons I'd be happy to add that.

[kcpevey]

This is all about the PolyEditTool.

That is primarily about interacting with vertices

I guess I never even considered that deleting the whole polygon was something it was NOT designed to do. How else would I delete a polygon?

[philippjfr]

This is all about the PolyEditTool.

Are you sure? The first line of the issue is about the PolyDrawTool.

I guess I never even considered that deleting the whole polygon was something it was NOT designed to do. How else would I delete a polygon?

Using the PolyDrawTool.

[kcpevey]

Are you sure?

Good call. 1 and 2 are about PolyDraw. 3, 4, and 5 are about PolyEdit.

I have mentioned before that the distinctions between these tools often leaves me confused. Especially since PointDraw has only one tool for all of its functionality. I recognize why there are two, I just have to relearn how it all works after a week of not looking at it. Every. single. time. (if I click will i end up moving the polygon? if I double click is that going to create a new vertex, a new polygon, or just highlight something? how can I delete this vertex/polygon - do I have to highlight it first?)

All that said, my understanding of the current state is:
PolyDrawTool - creation and deletion of polygons, moving polygons
PolyEditTool - moving/deleting vertices of existing polygons

My intuition wants:
PolyDrawTool - Creation of polygons
PolyEditTool - moving/deleting vertices of existing polygon, moving/deleting polygons

[kcpevey]

It would be great if these tools could be unified in some way. Need to think through how these tools could come together in one tool because of limitations in bokeh tools. Would need a lot of thought in terms of intuition of how this would work.