Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for FrankenPHP #675

Open
jwage opened this issue Dec 24, 2023 · 2 comments
Open

Add support for FrankenPHP #675

jwage opened this issue Dec 24, 2023 · 2 comments

Comments

@jwage
Copy link

jwage commented Dec 24, 2023

I’m interested in using FrankenPHP with Heroku. Would it be possible for me to add support to this buildpack or would a separate buildpack make sense?

https://frankenphp.dev/

@jwage
Copy link
Author

jwage commented Feb 9, 2024

@dzuelke thoughts on this? Would you accept a PR?

@dzuelke dzuelke mentioned this issue Feb 9, 2024
@dzuelke
Copy link
Contributor

dzuelke commented Feb 9, 2024

Hi Jon,

I'll need to look into it, it's been on my list for a while now.

The main question is whether it can be done as an alternative PHP runtime that's somehow selected for installation, or if it needs to be a separate buildpack.

Composer has no notion of FrankenPHP as a runtime, but since it needs ZTS anyway, maybe if we start providing ZTS builds, we could always include it there.

The other alternative is for the buildpacks' ZTS builds to enable the embed SAPI, and then have a separate, lightweight FrankenPHP buildpack on top, that uses the shared library.

I've created an issue (#695) to track the ZTS efforts more generally. Please note that that work is likely to not happen for this buildpack, but instead only for the CNB over at https://github.com/heroku/buildpacks-php.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants