Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

plugin bundling scripts need to check checksum when downloading #2539

Open
illume opened this issue Nov 7, 2024 · 0 comments
Open

plugin bundling scripts need to check checksum when downloading #2539

illume opened this issue Nov 7, 2024 · 0 comments
Labels
bug Something isn't working headlamp-plugin Related to the headlamp-plugin NPM package. plugins release Related to releasing security

Comments

@illume
Copy link
Collaborator

illume commented Nov 7, 2024

Describe the bug

There are some plugin bundling scripts for the app and the container image which download plugins without checking their checksums. The risk is that some files might be corrupted or changed.

Related files:

  • build-manifest.json
  • app-build-manifest.json
  • app/scripts/setup-plugins.js
  • container/fetch-plugins.sh

Probably there are other files that call these.

The package command generates a sha256 checksum, so probably we should use that?

We might want to think of this holistically as being part of the publishing process.

Additional Context

Probably this functionality should live in headlamp-plugin. Currently it's in two different scripts.

@illume illume added bug Something isn't working security plugins headlamp-plugin Related to the headlamp-plugin NPM package. labels Nov 7, 2024
@illume illume added the release Related to releasing label Nov 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working headlamp-plugin Related to the headlamp-plugin NPM package. plugins release Related to releasing security
Projects
Development

No branches or pull requests

1 participant