Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider methods to consolidate headers in nginx configuration #440

Open
phantomjinx opened this issue Apr 18, 2024 · 0 comments
Open

Consider methods to consolidate headers in nginx configuration #440

phantomjinx opened this issue Apr 18, 2024 · 0 comments
Assignees
Milestone

Comments

@phantomjinx
Copy link
Member

To conform with security requirements, the number of add_header config lines is proliferating in the nginx config template. One of the reasons for the number is that adding a single header in a location will not merge with the parent's set of headers but overwrite them!

Therefore, all parent headers must be specified again in a child location if the latter has an additional add_header entry.

There are workarounds to this that could be considered:

  • most_set_headers directive - provides an alternative merge-style directive to be used instead of add_header;
  • include directive - putting all the add_header entries into a single file then include that file with a single-line include directive.
@phantomjinx phantomjinx added this to the 2024Q2 milestone Apr 18, 2024
@lhein lhein moved this from New to Todo in Kanban Board Apr 25, 2024
@tadayosi tadayosi modified the milestones: 2024Q2, 2024Q3 Aug 2, 2024
phantomjinx added a commit to phantomjinx/hawtio-online that referenced this issue Oct 15, 2024
* Rather than repeating add_header directives, use 1-line include directives
  instead to bring import an additional file

* Makes the include files themselves hierarchical with further includes
  back to a single base include file
@phantomjinx phantomjinx modified the milestones: 2024Q3, 2024Q4 Oct 15, 2024
@phantomjinx phantomjinx self-assigned this Oct 15, 2024
phantomjinx added a commit that referenced this issue Oct 16, 2024
* Rather than repeating add_header directives, use 1-line include directives
  instead to bring import an additional file

* Makes the include files themselves hierarchical with further includes
  back to a single base include file
phantomjinx added a commit that referenced this issue Oct 21, 2024
* Rather than repeating add_header directives, use 1-line include directives
  instead to bring import an additional file

* Makes the include files themselves hierarchical with further includes
  back to a single base include file
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: In Review
Development

No branches or pull requests

2 participants