Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Notifications and discussions - parse error #504

Open
magthe opened this issue Mar 7, 2024 · 2 comments
Open

Notifications and discussions - parse error #504

magthe opened this issue Mar 7, 2024 · 2 comments

Comments

@magthe
Copy link

magthe commented Mar 7, 2024

I haven't researched this in detail yet, but there seems to be a difference in the shape of notifications for PRs and for discussions.

Earlier today I had three notifications in my inbox, 2 from discussions and 1 from a PR. When trying to fetch all notifications I received this error:

ParseError "Error in $[0].subject.url: parsing URL failed, expected String, but encountered Null"

I marked one of the discussion notifications as done, ran my code again and got the same parse error. Then I marked the second discussion notification as done, and when I ran my code after that it happily parsed the response with a single PR notification.

@magthe
Copy link
Author

magthe commented Mar 9, 2024

Now I've made a small change that solves the issue for me at least. This does go against the documentation, so arguably it should be pointed out to GitHub/Microsoft too.

My changes is here

@maralorn
Copy link

Yeah, also for GitHub actions in the notifications the subject url can be null. According to the published spec by github we are already not correct because subject "last comment url" is also often null, which this library apparently accepted.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants