Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a step0 in order to collect s2i image label #46

Open
cmoulliard opened this issue Jun 4, 2019 · 2 comments
Open

Add a step0 in order to collect s2i image label #46

cmoulliard opened this issue Jun 4, 2019 · 2 comments
Labels
enhancement New feature or request
Milestone

Comments

@cmoulliard
Copy link
Contributor

Feature

The Tekton Task responsible to perform the step buildah bud uses a hard coded value to specify the path to execute the command s2i. This parameter should be externalised like also the following s2i images labels using a step0 to correctly let s2i build --as-dockerfile to populate the dockerfile - see discussion

io.openshift.s2i.destination /tmp
io.openshift.s2i.scripts-url image:///usr/local/s2i
io.fabric8.s2i.version.maven 3.5
org.jboss.container.deployments-dir /deployments
...

Info coming from : https://access.redhat.com/containers/?tab=tech-details&get-method=red-hat-login#/registry.access.redhat.com/openjdk/openjdk-8-rhel8

The go containers image tool used by skopeo, buildah, ... provides a parse image function which can be used to collect such info from the s2i image selected

@cmoulliard cmoulliard added the enhancement New feature or request label Jun 4, 2019
@cmoulliard
Copy link
Contributor Author

Example of code implementation which is working to get the image labels : https://gist.github.com/cmoulliard/225a7e23900e2b056e738ad27611d19a

@cmoulliard cmoulliard added this to the v0.1.x milestone Aug 27, 2019
@metacosm metacosm modified the milestones: v0.1.x, v0.2.x Jan 21, 2020
@cmoulliard
Copy link
Contributor Author

As we have now a Runtime CRD definition, then I dont think that we still need such step0 task for tekton and we could use the Runtime CRD to include additional METADATA such as:

  • BaseImage to be used,
  • K8s Labels to be applied,
  • List of the commands to be used for oc or kubectl exec
    and map the Runtime parameters to the TaskRun

WDYT @metacosm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants