Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

1.0.5 on NPM has incorrect name in UMD bundle #1

Open
jackwilsdon opened this issue Aug 13, 2024 · 1 comment
Open

1.0.5 on NPM has incorrect name in UMD bundle #1

jackwilsdon opened this issue Aug 13, 2024 · 1 comment

Comments

@jackwilsdon
Copy link

Version 1.0.5 on NPM has OPT instead of OTP as the library name in the UMD bundle (meaning you have to use window.OPT instead of window.OTP).

It looks like this was fixed in 79f9730, but the version on NPM doesn't contain this fix.

The issue can be seen here: https://cdn.jsdelivr.net/npm/[email protected]/dist/index.umd.min.js
@haikelfazzani
Copy link
Owner

haikelfazzani commented Aug 13, 2024 •
edited
Loading

  • The issue has been resolved and is included in version 1.0.6.
  • Additional tests have been added.

jsfiddle demo

Thank you for reporting the issue. We appreciate your help in improving our package.

@haikelfazzani haikelfazzani reopened this Aug 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jackwilsdon @haikelfazzani