Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Identifier as a type, not an alias #47

Open
hadronized opened this issue Nov 18, 2018 · 1 comment
Open

Add Identifier as a type, not an alias #47

hadronized opened this issue Nov 18, 2018 · 1 comment
Labels
easy enhancement good first issue

Comments

@hadronized
Copy link
Owner

That type would ensure the grammar is respected:

  • It doesn’t have its first character a digit or anything else than a lowercase or uppercase ASCII alpha.
  • It’s not empty.
This was referenced Nov 18, 2018
Open
Open
hadronized added a commit that referenced this issue Nov 20, 2018
@hadronized
Change the NonEmpty, Identifier and TranslationUnit types. #47
45832ff 
They’re now type wrappers and not type aliases. Also, add the TypeName
type wrapper.
hadronized added a commit that referenced this issue Nov 20, 2018
@hadronized
Change the NonEmpty, Identifier and TranslationUnit types. #47
4e8e004 
They’re now type wrappers and not type aliases. Also, add the TypeName
type wrapper.
hadronized added a commit that referenced this issue Nov 20, 2018
@hadronized
Change the NonEmpty, Identifier and TranslationUnit types. #47
fd97ffc 
They’re now type wrappers and not type aliases. Also, add the TypeName
type wrapper.
@hadronized
Copy link
Owner Author

It’s not an alias anymore, but type safety is not enforced. We have to take care of that.

hadronized added a commit that referenced this issue Nov 21, 2018
@hadronized
Add functions to create Identifier and TypeName in safe ways. #47
558c1dc 
Those functions are not enforced (yet), as people can still use the
From<&str> / From<String> interface, but we’re getting there.
hadronized added a commit that referenced this issue Nov 21, 2018
@hadronized
Add functions to create Identifier and TypeName in safe ways. #47
7cf1ec2 
Those functions are not enforced (yet), as people can still use the
From<&str> / From<String> interface, but we’re getting there.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
easy enhancement good first issue
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@hadronized