Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GWT 2.12 deprecations/removals #9923

Closed
niloc132 opened this issue Feb 12, 2024 · 4 comments · Fixed by #9925
Closed

GWT 2.12 deprecations/removals #9923

niloc132 opened this issue Feb 12, 2024 · 4 comments · Fixed by #9925

Comments

@niloc132
Copy link
Contributor

niloc132 commented Feb 12, 2024

This issue will discuss unused classes to deprecate and remove in 2.12 - if you have questions, or need to find another way to do something, please discuss here.

Removal - types that have been deprecated and are not typically part of the public API:

  • com.google.gwt.dev.util.arg.ArgHandlerLibraries - no longer used as of GWT 2.8.
  • com.google.gwt.dev.util.arg.ArgHandlerLink - no longer used as of GWT 2.8.
  • com.google.gwt.dev.util.arg.ArgHandlerOutputLibrary - no longer used as of GWT 2.8.
  • com.google.gwt.dev.shell.HostedModeServletConfigProxy - last used by GWTShellServlet, removed as of GWT 2.6. This wasn't deprecated, but was package-protected.
  • com.google.gwt.dev.shell.rewrite.ForceClassVersion15 - used when running legacy dev mode with Java <1.8.
  • com.google.gwt.dev.util.arg.ArgHandlerStrictResources - logged deprecation warnings when used, has had no effect since before 2.8.
  • com.google.gwt.dev.util.arg.ArgHandlerOverlappingSourceWarnings - logged deprecation warnings when used, has had no effect since before 2.8.
  • com.google.gwt.dev.util.arg.ArgHandlerMissingDepsFile - logged deprecation warnings when used, has had no effect since before 2.8.
  • com.google.gwt.dev.util.arg.ArgHandlerIncrementalCompileWarnings - logged deprecation warnings when used, has had no effect since before 2.8.
  • com.google.gwt.dev.util.arg.ArgHandlerDeprecatedDisableUpdateCheck - logged deprecation warnings when used, has had no effect since before 2.9.

Deprecation, to be removed in a future release - these are not currently used by GWT itself (and have not been for some time), and will be removed in the future:

  • com.google.gwt.dev.GetJreEmulation - runnable main that appears to list jre emulation, like the JavaEmulSummaryDoclet (formerly ezt doclet).
    • com.google.gwt.dev.SignatureDumper - package-protected class used in GetJreEmulation.
  • com.google.gwt.dev.RunWebApp - runnable main that appears to run the JettyLauncher (deprecated in GWT 2.11), without the rest of dev mode.
  • com.google.gwt.dev.shell.log.ServletContextTreeLogger - like HostedModeServletConfigProxy, this was part of GWTShellServlet, but wasn't removed. This was public, so leaving it for another release.
  • com.google.gwt.dev.shell.WorkDirs - Was used in GWTShell, also removed in GWT 2.6. This was public, leaving it for another release.
@niloc132
Copy link
Contributor Author

niloc132 commented Apr 24, 2024

@niloc132
Copy link
Contributor Author

niloc132 commented Jul 17, 2024

  • Also com.google.web.bindery.requestfactory.server.RequestFactoryJarExtractor, which is currently shipped in several jars, but really should only be part of the build. No intent to delete this class, but just stop shipping it.

@niloc132
Copy link
Contributor Author

niloc132 commented Jul 31, 2024

  • com.google.gwt.user.tools.util.CreatorUtilities only has one method used - was previously created for ApplicationCreator, which was rewritten as WebAppCreator
  • com.google.gwt.user.tools.ApplicationCreator now just logs an error, points the user at WebAppCreator.
  • com.google.gwt.user.tools.ProjectCreator now just logs an error, points the user at WebAppCreator.
  • com.google.gwt.user.tools.util.ArgHandlerAddToClassPath is unused, formerly used by ApplicationCreator

@niloc132
Copy link
Contributor Author

niloc132 commented Oct 7, 2024

Speedtracer classes - the speedtracer tools no longer run as far as we can tell, so we'll intend to remove these in the future and replace with some other metrics - consider jdk.jfr.Event apis or the like? See #10007 for later followup.

  • com.google.gwt.dev.util.log.speedtracer.SpeedTracerLogger
  • com.google.gwt.dev.util.log.speedtracer.SpeedTracerEventType
  • com.google.gwt.dev.util.log.speedtracer.CompilerEventType
  • com.google.gwt.dev.util.log.speedtracer.DevModeEventType

May also want to consider removing com.google.gwt.dev.util.log.MetricName/com.google.gwt.dev.util.log.MetricMap, an enum with only one value, and add special cased logging for this purpose.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant