Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move Symbol to shared together with jvm specific domain tests. #264

Closed
wants to merge 1 commit into from
Closed

Move Symbol to shared together with jvm specific domain tests. #264

wants to merge 1 commit into from

Conversation

mikla
Copy link

@mikla mikla commented Apr 13, 2023

Closes #261

  • Symbol was moved to domain/shared
  • Decided to move all domain/jvm test to domain/shared. So they are run agains JS and JVM right now.
  • Added .sbtopts as sbt test started to fail with OOM.

Hope I didn't break anything. 🤞

@gvolpe
Copy link
Owner

gvolpe commented Apr 14, 2023

Hey @mikla thanks for doing this. I won't be merging it, though, because I want the main branch to reflect what's in the book. Nevertheless, I think this is a good reference for everyone now that Iron supports Scala.js.

@gvolpe gvolpe closed this Apr 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Move trading.domain.Symbol to shared
2 participants
@mikla @gvolpe