Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

REST API features #32

Open
kamikazechaser opened this issue Oct 16, 2024 · 2 comments
Open

REST API features #32

kamikazechaser opened this issue Oct 16, 2024 · 2 comments
Labels
enhancement New feature or request sarafu.network

Comments

@kamikazechaser
Copy link
Contributor

  • Support both a service API key and end user authentication and authorization (Though the deployments should be separate just to reduce damage in the event of a critical security issue).
  • Middlewares for further checks on request parameters. E.g. banned tokens, pools and users
  • Optional rate limiting based on both origin I.P address and publicKey. This is particularly useful for publicly exposed custodial endpoints.
  • CORS support
@kamikazechaser
Copy link
Contributor Author

Switched to EdDSA JWT only. Services can get long lived JWT via the gen-service-token CLI. Default expiry is 1 day for non-service use cases.

@kamikazechaser
Copy link
Contributor Author

We should probably move to a framework that supports finer control over middleware. Echo suffices for now but may introduce a lot of boilerplate and repeated code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request sarafu.network
Projects
Development

No branches or pull requests

1 participant