Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Mypy type hinting #1438

Open
PureTryOut opened this issue Jul 27, 2023 · 6 comments
Open

Add support for Mypy type hinting #1438

PureTryOut opened this issue Jul 27, 2023 · 6 comments

Comments

@PureTryOut
Copy link

Is your feature request related to a problem? Please describe.
Our codebase is type checked using type hinting. There are stub packages for Django but graphene-django seems to be lacking it, thus importing anything from it causes Mypy to complain that error: Skipping analyzing "graphene_django": module is installed, but missing library stubs or py.typed marker [import]. It does so for just graphene as well.

Describe the solution you'd like
graphene-django to export type hints.

@ryanovas
Copy link

ryanovas commented Sep 3, 2023

seconded

@ghost
Copy link

ghost commented Sep 23, 2023

If the maintainers approve, then I can start adding types to graphene-django, and in general graphene

@50-Course
Copy link

seconded. It would seem this involve project-wide type hinting? @PureTryOut

@PureTryOut
Copy link
Author

I'm not sure what you want me to answer? I don't know, I'm not involved in development of this project, just a user.

@50-Course
Copy link

Thank you for clarifying. I have just gone through the source code myself. Thanks for signifying :)

@firaskafri
Copy link
Collaborator

If the maintainers approve, then I can start adding types to graphene-django, and in general graphene

I thin its a good idea.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants