Enable service account token auth for public API #5254
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matiasb
added
pr:no public docs
matiasb
force-pushed
the
matiasb/public-api-service-account-auth
branch
from
1e382db
to
29c3858
Compare
matiasb
commented
Nov 14, 2024
| related_name="alert_receive_channels", | ||
| blank=True, | ||
| null=True, | ||
| ) |
There was a problem hiding this comment.
Added to keep track of integrations created via a service account token.
| organization = Organization.objects.filter(grafana_url=grafana_url).first() | ||
| if organization: | ||
| return organization | ||
|
|
There was a problem hiding this comment.
We need a way to identify the Grafana URL to hit its API when validating a service account token (note Grafana URL is already a param in Terraform)
| permissions = get_service_account_token_permissions(organization, token) | ||
| if not permissions: | ||
| try: | ||
| user, auth_token = ServiceAccountToken.validate_token(organization, token) |
There was a problem hiding this comment.
Validation is moved to the ServiceAccountToken model.
| return super().get_queryset().select_related("service_account__organization") | ||
|
|
||
|
|
||
| class ServiceAccountToken(BaseAuthToken): |
There was a problem hiding this comment.
The most relevant bits of this PR are here.
matiasb
force-pushed
the
matiasb/public-api-service-account-auth
branch
from
29c3858
to
35a13bc
Compare
matiasb
force-pushed
the
matiasb/public-api-service-account-auth
branch
from
35a13bc
to
b1aa482
Compare
mderynck
reviewed
Nov 15, 2024
matiasb
force-pushed
the
matiasb/public-api-service-account-auth
branch
from
5f6712b
to
1bb8e0d
Compare
matiasb
force-pushed
the
matiasb/public-api-service-account-auth
branch
from
1bb8e0d
to
cfc29f7
Compare
mderynck
approved these changes
Nov 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to https://github.com/grafana/oncall-private/issues/2826
Continuing work started in #5211, this adds support for Grafana service accounts tokens for API authentication (except alert group actions which will still require a user behind). Next steps would be updating the go client and the terraform provider to allow service account token auth for OnCall resources.
Following proposal 1.1 from doc.