Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ExpandedPostings: Allow promise execution when context was canceled but other callers are still waiting for results #331

Open
colega opened this issue Oct 11, 2021 · 3 comments

Comments

@colega
Copy link
Contributor

colega commented Oct 11, 2021

Is your feature request related to a problem? Please describe.
See #330 (comment)

When the context of the promise creator for ExpandedPostings is canceled, the promise will be canceled, even if there are other callers waiting for the promise result.

Describe the solution you'd like
Promise should be still executed when someone is waiting for its results.

Describe alternatives you've considered
Just let it be as it's now, because probably the entire request was canceled (promise share requests from same sharded query, if one sharded query is canceled, the other one is too, isn't it true?)

Additional context
#329

@colega colega changed the title Allow promise execution when context was canceled but other callers are waiting ExpandedPostings: Allow promise execution when context was canceled but other callers are still waiting for results Oct 11, 2021
@colega
Copy link
Contributor Author

colega commented Dec 24, 2021

@pracucci I think I'll close this issue, this doesn't seem to happen, and the day it will happen it will probably be because the entire sharded request was cancelled, as that is where we hit the promise.

@colega colega reopened this Oct 23, 2023
@aknuds1
Copy link
Contributor

aknuds1 commented Oct 23, 2023

Similar to grafana/mimir-prometheus#548.

@dimitarvdimitrov
Copy link
Contributor

This is still relevant. It happened today:

Image

Context tracking is already implemented for prometheus in grafana/mimir-prometheus#644 we can probably just copy that implementation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants