Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Helm Chart] Global annotations and labels should be defined under global (not loki) #14773

Open
siegenthalerroger opened this issue Nov 5, 2024 · 0 comments
Labels
area/helm type/feature Something new we should do

Comments

@siegenthalerroger
Copy link

Describe the bug

In the helm chart values it is confusing when the values are defined under the "loki" or under the "global" top level key.

Expected behavior

It would be preferable if there was a distinction between k8s/deployment and loki configuration, placing the former under the "global" key.

Environment:

  • Infrastructure: Kubernetes
  • Deployment tool: helm
@JStickler JStickler added type/feature Something new we should do area/helm labels Nov 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/helm type/feature Something new we should do
Projects
None yet
Development

No branches or pull requests

2 participants