Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should look for 1build.yaml in ancestors and fetch the closest one (like git) #91

Open
AdeshAtole opened this issue Jun 11, 2019 · 3 comments
Labels
hold Further information is requested

Comments

@AdeshAtole
Copy link

Description

Some codebases have build commands run from sub directories as well as from main project dir. Can be managed with multiple 1build.yamls , but good to have a single one across project.

@AdeshAtole AdeshAtole changed the title Should look for 1build.yaml in parent and fetch the closest one Should look for 1build.yaml in ancestors and fetch the closest one Jun 11, 2019
@AdeshAtole AdeshAtole changed the title Should look for 1build.yaml in ancestors and fetch the closest one Should look for 1build.yaml in ancestors and fetch the closest one (like git) Jun 11, 2019
@AdeshAtole AdeshAtole changed the title Should look for 1build.yaml in ancestors and fetch the closest one (like git) Should look for 1build.yaml in ancestors and fetch the closest one (like git) Jun 11, 2019
AdeshAtole added a commit to AdeshAtole/1build that referenced this issue Jun 11, 2019
@AdeshAtole AdeshAtole mentioned this issue Jun 11, 2019
3 tasks
AdeshAtole added a commit to AdeshAtole/1build that referenced this issue Jun 11, 2019
@alexluix
Copy link
Collaborator

@AdeshAtole what if commands are supposed to run from the working directory? should the tool automatically switch to the working directory and run the command?

We gave it a thought and decided to hold this one until the demand is more clear.

In the meantime, I would suggest solving your requirement with a symlink – should work if the number of subfolders is not large.

We appreciate your proactiveness and the PR – but please make sure that the issue is discussed before implementing it – revisit our Contribution page for more details.

https://github.com/gopinath-langote/1build/blob/master/CONTRIBUTING.md

@alexluix
Copy link
Collaborator

@AdeshAtole we are looking forward to hearing more feedback about your subfolder issue and if symlinks work for you.

In the meantime feel free to pick up an issue with a help wanted label from our backlog – https://github.com/gopinath-langote/1build/issues?q=is%3Aopen+is%3Aissue+label%3A%22help+wanted%22

Just updated the contributing page to clarify the procedure.

@gopinath-langote gopinath-langote added the hold Further information is requested label Jun 11, 2019
@AdeshAtole
Copy link
Author

@landpro Yes, symlinks should suffice me for now. The idea was to have 1build analogous to git, where git works anywhere in the subtree.

what if commands are supposed to run from the working directory? should the tool automatically switch to the working directory and run the command?

This question isn't clear to me. 1build commands always run in current working directory, right?

It does make sense to keep this on hold till things get finalised.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hold Further information is requested
Projects
None yet
Development

No branches or pull requests

3 participants