Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Always default default the JWT audience to the primary bigtable.googleapis.com authority #2262

Open
igorbernstein2 opened this issue Jun 20, 2024 · 0 comments
Labels
api: bigtable Issues related to the googleapis/java-bigtable API. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.

Comments

@igorbernstein2
Copy link
Contributor

Currently the JWT audience is derived from the endpoint. This works well when the endpoint is bigtable.googleapis.com. However when a different endpoint is used to reach cloud bigtable, this doesnt work as well. The EnhancedStubSettings has a way to new mappings between endpoints and authorities via JwtAudienceMapping, by default this has a mapping for batch-bigtable.googleapis.com.

However with psc, having multiple endpoints targeting the same authority is the norm. So the mapping should ignore the endpoint and simply default to bigtable.googleapis.com unless there is an override

@product-auto-label product-auto-label bot added the api: bigtable Issues related to the googleapis/java-bigtable API. label Jun 20, 2024
@igorbernstein2 igorbernstein2 added type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. and removed api: bigtable Issues related to the googleapis/java-bigtable API. labels Jun 20, 2024
@product-auto-label product-auto-label bot added the api: bigtable Issues related to the googleapis/java-bigtable API. label Jun 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: bigtable Issues related to the googleapis/java-bigtable API. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.
Projects
None yet
Development

No branches or pull requests

1 participant