Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix centipede exceptions #4187

Open
jonathanmetzman opened this issue Aug 19, 2024 · 4 comments
Open

Fix centipede exceptions #4187

jonathanmetzman opened this issue Aug 19, 2024 · 4 comments
Assignees

Comments

@jonathanmetzman
Copy link
Collaborator

jonathanmetzman commented Aug 19, 2024

It's exceptioning all over the place in oss-fuzz.
#4040 seems broken becuase it's having oss-fuzz run fuzzers for builds that aren't happening. I think projects aren't being built with centipede by default on oss-fuzz.

@jonathanmetzman jonathanmetzman changed the title Fix centipede breakage Fix centipede exceptions Aug 19, 2024
@jonathanmetzman
Copy link
Collaborator Author

jonathanmetzman commented Aug 19, 2024

See gs://clusterfuzz-builds-centipede/hwloc/ or fftw3.
I think we should talk about whether we want to force centipede on new projects at this point, so I'm not sure the right move is to enable the builds on the oss-fuzz side. I imagine this will cause many build fails.
But for now, since builds on the oss-fuzz side are opt-in, making this opt-out is not helping anyone. I will revert for now. Sorry, but I want to see a more accurate picture of the health of oss-fuzz before I go on vacation.

@jonathanmetzman
Copy link
Collaborator Author

jonathanmetzman commented Aug 19, 2024

Skia noticed this caused weird behavior where the old build (from April 2023) was used https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=71292 causing bugs to be filed for extremely old builds.

@jonathanmetzman
Copy link
Collaborator Author

About 50 bugs were opened in the past few days for centipede, 17 of which are security bugs (usually there none)
I think all of these are suspect.

jonathanmetzman added a commit that referenced this issue Aug 19, 2024
This reverts commit 153c555.
We shouldn't make oss-fuzz jobs for centipede opt-out if builds are
opt-out.

Related: #4187
jonathanmetzman added a commit that referenced this issue Aug 19, 2024
This reverts commit 153c555.
We shouldn't make oss-fuzz jobs for centipede opt-out if builds are
opt-out.

Related: #4187
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants