Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider archiving this repository, and pointing folks to github.com/rs/cors instead. #42

Open
dzrw opened this issue Sep 5, 2018 · 3 comments

Comments

@dzrw
Copy link

dzrw commented Sep 5, 2018

This package appears as the top search result on Google for gin gonic cors, but has a number of trouble spots that make it hard to use correctly the first time. I'm sure there's a good reason for the design, but the README doesn't make its gotchas obvious.

  • The Origin header issue
  • The explicit OPTIONS handler issue
  • The "does not work at the group level" issue

Instead, consider pointing users to https://github.com/rs/cors and its gin-gonic example.

@codingdiaz
Copy link

I spent two hours trying to get his package to work. Went over to rs/cors and got it working in 1 minute.

@gabstv
Copy link

gabstv commented Apr 11, 2019

@politician thank you for the https://github.com/rs/cors alternative!

@clarkmcc
Copy link

I spent two hours trying to get his package to work. Went over to rs/cors and got it working in 1 minute.

Same.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants