Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only Gauge definitions available within package_to_scan should be considered #168

Open
sswaroopgupta opened this issue Jun 26, 2018 · 2 comments

Comments

@sswaroopgupta
Copy link
Contributor

sswaroopgupta commented Jun 26, 2018

Actual behavior
All the definitions in the project are considered.

Steps to replicate

  • Create a java_maven project with grp1 as the default package
  • Create another package one.level
  • Add a new step implementation to the new package
  • Add a custom Parser to the new package
  • Use the step in the example.spec with a custom parameter defined
  • Configure package_to_scan = grp1
  • Reload the project
  • Run the specifications

All the steps are successfully executed. But, the definitions outside grp1 should not be considered

Sample project - art2.zip

Version

Gauge version: 1.0.1.nightly-2018-06-19
Commit Hash: 583ef1d

Plugins
-------
java (0.6.9.nightly-2018-06-12)

Blocks #161

@sswaroopgupta sswaroopgupta added this to the 1.1 milestone Jun 26, 2018
@ghost ghost assigned BugDiver Jun 27, 2018
@ghost ghost added in progress and removed ready labels Jun 27, 2018
@BugDiver
Copy link
Member

Fix should be available in nightly >= 28 June 2018

@sswaroopgupta
Copy link
Contributor Author

Only Custom Parameters defined within the package_to_scan should be considered. Currently it considers all definitions.

Steps to replicate
Same as the original issue.

@nehashri nehashri added tiage and removed ready labels Aug 8, 2018
@zabil zabil removed this from the 1.1 milestone Sep 24, 2018
@zabil zabil removed the triage label Sep 24, 2018
@nehashri nehashri added triage and removed tiage labels Feb 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

4 participants