Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Output sea flux species dry deposition velocity with DryDep collection #2564

Open
eamarais opened this issue Nov 8, 2024 · 0 comments
Open
Assignees
Labels
category: Feature Request New feature or request topic: Deposition Related to dry deposition or wet depostion proceses

Comments

@eamarais
Copy link

eamarais commented Nov 8, 2024

Your name

Eloise Marais

Your affiliation

UCL, UK

Provide a clear and concise overview of the new feature requested.

Currently dry deposition velocities calculated in HEMCO for seaflux species like ACET aren’t output with the DryDep diagnostic. The values over the ocean are all zero. Velocities can be output with HEMCO diagnostics, but the values being output are odd (orders of magnitude from what's expected), suggesting a unit conversion error perhaps.

To address absence of seaflux species dry dep velocities over the ocean, I’ve simply moved where DryDepVel is archived from drydep_mod.F90 to hco_interface_gc_mod.F90. This places it in the same location as Archive_DryDep and Archive_DryDepMix. I’ve also moved the SatDiagnDryDepVel diagnostic. I haven’t moved the ConcAboveSurf drydepvel diagnostic, as I can’t quite make sense of what values it’s collecting in drydep_mod.F90 and I’m also not familiar with this diagnostic.

I’ve tested that the updated code works by comparing velocities for acetone (ACET) from the DryDep and SatDiagn collection (images below). In the original code, values are 0.1 cm/s over land and zero over the ocean, whereas in the updated code, the values calculated in HEMCO extension hcox_seaflux_mod.F90 are also output. I’ve also compared NO2 (images below) to confirm that the updated code doesn’t affect velocities of other species with no seaflux.

I’ve uploaded a patch that includes 2 code commits. The first updates the DryDep collection and the second updates the SatDiagn collection.

The patch also includes a very minor code update that changes indices in hco_interface_gc_mod.F90 from (:,:) to (I,J), as these occur within a lat, long loop.

Screenshot 2024-11-08 at 10 33 52

Screenshot 2024-11-08 at 10 35 20

Reference(s)

No response

Will you be implementing this feature yourself?

Yes

Additional information

Patch to apply changes that move drydepvel output from drydep_mod to hco_interface_gc_mod:
move-drydepvel-drydep-satdiagn.patch.zip

@eamarais eamarais added the category: Feature Request New feature or request label Nov 8, 2024
@yantosca yantosca self-assigned this Nov 8, 2024
@yantosca yantosca added the topic: Deposition Related to dry deposition or wet depostion proceses label Nov 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category: Feature Request New feature or request topic: Deposition Related to dry deposition or wet depostion proceses
Projects
None yet
Development

No branches or pull requests

2 participants