Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE REQUEST] Transport tracer benchmark improvements #288

Open
lizziel opened this issue Jan 25, 2024 · 2 comments · Fixed by #305
Open

[FEATURE REQUEST] Transport tracer benchmark improvements #288

lizziel opened this issue Jan 25, 2024 · 2 comments · Fixed by #305
Assignees
Labels
category: Feature Request New feature or request topic: Benchmark Plots and Tables Issues pertaining to generating plots/tables from benchmark output

Comments

@lizziel
Copy link
Contributor

lizziel commented Jan 25, 2024

Name and Institution (Required)

Name: Lizzie Lundgren
Institution: Harvard University

New GCPy feature or discussion

This issue is to document some nice-to-haves that I notice as I run the transport tracer benchmark code. None of this is urgent or even necessary, but it would be good to list it somewhere. Maybe one day we can make the updates.

  1. Copy the yaml configuration file to each of the benchmark output folders. This would give a record of the paths and settings used when running the benchmark and make it easier to rerun.
  2. An alternative to 1 above is to print all of the data path information to the log. Currently the log includes the path to the species database but not the paths to the data being compared.
  3. It would be useful to create mass conservation tables for both ref and dev. Right now you can only generate it for dev.
  4. The passive mass table (global mass time series) does not include version string in header and also only prints dev. It would be easier to read if the version string is included (not just the run directory name), along with both ref and dev.
  5. Compare ref and dev RnPbBe budget tables in one file. Currently ref and dev are sent to separate files and no comparison is done.
  6. Include day of month in mass table filenames. It is not obvious from the filename (e.g. Oct2019, Apr2019) that the mass is taken from the restart file and therefore is an instantaneous value.
  7. Include emissions plots and tables like we do for the full chemistry simulation.

I will keep adding to this as I run into more.

@yantosca
Copy link
Contributor

@lizziel: Several of these updates are being addressed by PR #305.

@yantosca
Copy link
Contributor

Point 3 above is being addressed by PR #309

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category: Feature Request New feature or request topic: Benchmark Plots and Tables Issues pertaining to generating plots/tables from benchmark output
Projects
None yet
2 participants