Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG/ISSUE] Budget operations table not working for GCHP data sets #217

Open
lizziel opened this issue May 15, 2023 · 4 comments
Open

[BUG/ISSUE] Budget operations table not working for GCHP data sets #217

lizziel opened this issue May 15, 2023 · 4 comments
Labels
category: Bug Something isn't working never stale Never label this issue as stale topic: Benchmark Plots and Tables Issues pertaining to generating plots/tables from benchmark output

Comments

@lizziel
Copy link
Contributor

lizziel commented May 15, 2023

Describe the bug

In testing a different GCPy feature I noticed that the budget operations table values for GCHP are always NaN. For example, here is a GCHP vs GCHP table using the same ref and dev for simplicity.

SOAIE budgets (Ref=14.2.0; Dev=14.2.0)
Full [Gg] : SOAIE
+-------------+-------+-------+--------+------------+
| Operation   |   Ref |   Dev |   Diff |   Pct_diff |
|-------------+-------+-------+--------+------------|
| Chemistry   |   nan |   nan |    nan |        nan |
| Convection  |   nan |   nan |    nan |        nan |
| EmisDryDep  |   nan |   nan |    nan |        nan |
| Mixing      |   nan |   nan |    nan |        nan |
| WetDep      |   nan |   nan |    nan |        nan |
+-------------+-------+-------+--------+------------+

This happens when comparing GCHP (Dev) and GCC (Ref) as well.

ACET budgets (Ref=14.2.0; Dev=14.2.0)
Full [Gg] : ACET
+-------------+----------+-----------+-----------+------------+
| Operation   |      Ref |       Dev |      Diff |   Pct_diff |
|-------------+----------+-----------+-----------+------------|
| Chemistry   | -3.93806 | nan       | nan       |        nan |
| Convection  | -0.00000 | nan       | nan       |        nan |
| EmisDryDep  |  0.00004 | nan       | nan       |        nan |
| Mixing      |  3.11183 | nan       | nan       |        nan |
| WetDep      |  0.00000 |   0.00000 |   0.00000 |        nan |
+-------------+----------+-----------+-----------+------------+

I verified that there are no NaN values in the dataset.

To Reproduce

Turn budget table on when running a 1-month benchmarking with GCHP as dev, or both ref and dev. For my test I used output from a 1-hr run to generate the tables.

Expected behavior

There should be real values in the table for GCHP.

Additional context

This is not an urgent problem because we do not have the operation budget table turned on in GEOS-Chem benchmarking. However, I would like to get this fixed at some point.

@lizziel lizziel added the category: Bug Something isn't working label May 15, 2023
@stale
Copy link

stale bot commented Jun 23, 2023

This issue has been automatically marked as stale because it has not had recent activity. If there are no updates within 7 days it will be closed. You can add the "never stale" tag to prevent the Stale bot from closing this issue.

@stale stale bot added the stale No recent activity on this issue label Jun 23, 2023
@yantosca yantosca added the topic: Benchmark Plots and Tables Issues pertaining to generating plots/tables from benchmark output label Jun 27, 2023
@stale stale bot removed the stale No recent activity on this issue label Jun 27, 2023
@yantosca yantosca added the never stale Never label this issue as stale label Jun 27, 2023
Copy link

Stale issue message

Copy link

Stale issue message

@lizziel
Copy link
Contributor Author

lizziel commented Jan 22, 2024

I will test this again for my upcoming budget diagnostic PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category: Bug Something isn't working never stale Never label this issue as stale topic: Benchmark Plots and Tables Issues pertaining to generating plots/tables from benchmark output
Projects
None yet
Development

No branches or pull requests

2 participants