Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEATURE REQUEST]: Further DRY out various benchmark plotting scripts #141

Open
laestrada opened this issue Mar 17, 2022 · 4 comments
Open

[FEATURE REQUEST]: Further DRY out various benchmark plotting scripts #141

laestrada opened this issue Mar 17, 2022 · 4 comments
Assignees
@yantosca @laestrada
Labels
category: Feature Request New feature or request never stale Never label this issue as stale topic: Benchmark Plots and Tables Issues pertaining to generating plots/tables from benchmark output topic: Structural Modifications Related to GCPy structural modifications (as opposed to scientific updates)

Comments

@laestrada
Copy link
Contributor

Add your feature request below:

The run_benchmark.py, run_1yr_fullchem_benchmark.py, and run_1yr_tt_benchmark.py files have a significant amount of duplicate code. This should be decomposed/ modularized further in the future.
@laestrada laestrada added the category: Feature Request New feature or request label Mar 17, 2022
@laestrada laestrada self-assigned this Mar 17, 2022
@yantosca yantosca added the topic: Benchmark Plots and Tables Issues pertaining to generating plots/tables from benchmark output label Aug 30, 2022
@yantosca yantosca self-assigned this Sep 27, 2022
@yantosca yantosca mentioned this issue Oct 6, 2022
Closed
@yantosca yantosca added the topic: Structural Modifications Related to GCPy structural modifications (as opposed to scientific updates) label Oct 6, 2022
@github-actions GitHub Actions
Copy link

Stale issue message

@yantosca yantosca reopened this Nov 30, 2023
@yantosca yantosca added never stale Never label this issue as stale and removed no-issue-activity labels Nov 30, 2023
@yantosca
Copy link
Contributor

PR #280 has started this process by adding make_benchmark_drydep_plots to gcpy/benchmark/modules/benchmark_drydep.py (instead of jamming this routine into an already too-long gcpy/benchmark_funcs.py). We have also added gcpy/benchmark/modules/benchmark_utils.py, where we can continue to include benchmark-specific utility functions peeled out from the gcpy folder.

@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 9, 2024

Stale issue message

@yantosca yantosca mentioned this issue Feb 22, 2024
Open
1 task
@yantosca
Copy link
Contributor

In GCPy 1.5.0, several benchmark plots have been modified to use common routines. Also we have started to split benchmarking routines out of e.g. gcpy.benchmark.modules.benchmark_funcs into separate modules. The work is ongoing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@yantosca yantosca

@laestrada laestrada

Labels
category: Feature Request New feature or request never stale Never label this issue as stale topic: Benchmark Plots and Tables Issues pertaining to generating plots/tables from benchmark output topic: Structural Modifications Related to GCPy structural modifications (as opposed to scientific updates)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@yantosca @laestrada