Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG/ISSUE] Offline emissions are not updated at the correct frequency #184

Open
viral211 opened this issue Dec 19, 2022 · 3 comments
Open
Assignees
Labels
category: Bug Something isn't working never stale Never label this issue as stale topic: Configuration Files Related to HEMCO configuration files topic: Input Data Related to input/emissions data, or disk read/write operations

Comments

@viral211
Copy link

I am running HEMCO with GEOS-Chem classic version 14.0 and am using offline emissions for dust, sea salt, etc. I noticed that the emissions are not updated at the right frequency. For example, the offline dust emission settings in the default FullChem HEMCO_Config.rc file are as follows:

#==============================================================================
# --- Offline dust emissions ---
#==============================================================================
(((OFFLINE_DUST
(((.not.DustDead.or.DustGinoux
0 EMIS_DST1 $ROOT/OFFLINE_DUST/v2021-08/${RUNDIR_MET_NATIVE_RES}/$YYYY/$MM/dust_emissions_${RUNDIR_MET_LAT_RES}.$YYYY$MM$DD.nc EMIS_DST1 1980-2022/1-12/1-31/* EF xy kg/m2/s DST1 - 3 2

The dust emissions emissions should be updated daily, but instead they are read in just once at the beginning of the simulation. This applies to sea salt aerosols, soil NOx and biogenic VOC emissions also. I can get this to work correctly when I change the cycle flag from 'EF' to 'C', which was the flag used in previous model versions. I think the problem might be here:

! If the file has cycle flag "E" (e.g. it's a restart file), then we will
! read it only once and then never again. If the file has already been
! read on a previous call, then don't call HCOIO_READ. (bmy, 10/4/18)
!
! Moved this handling from hcoio_dataread_mod, as it is non-MAPL specific
! (hplin, 4/5/21)
IF ( Lct%Dct%Dta%CycleFlag == HCO_CFLAG_EXACT .and. &
Lct%Dct%Dta%UpdtFlag == HCO_UFLAG_ONCE .and. &
Lct%Dct%Dta%isTouched ) THEN
! Print a warning message only once
IF ( doPrintWarning ) THEN
doPrintWarning = .FALSE.
MSG = 'No further attempts will be made to read file: ' // &
TRIM( Lct%Dct%Dta%NcFile )
CALL HCO_WARNING ( HcoState%Config%Err, MSG, RC, WARNLEV=1 )
ENDIF
! Return without reading
CALL HCO_LEAVE( HcoState%Config%Err, RC )
RETURN
ENDIF

@viral211 viral211 added the category: Bug Something isn't working label Dec 19, 2022
@yantosca
Copy link
Contributor

Thanks @viral211, we'll take a look. Also tagging @msulprizio @Jourdan-He @SaptSinha @jimmielin

@yantosca yantosca added topic: Input Data Related to input/emissions data, or disk read/write operations topic: Configuration Files Related to HEMCO configuration files labels Dec 19, 2022
@yantosca yantosca self-assigned this Dec 19, 2022
@stale
Copy link

stale bot commented Jan 20, 2023

This issue has been automatically marked as stale because it has not had recent activity. If there are no updates within 7 days it will be closed. You can add the "never stale" tag to prevent the Stale bot from closing this issue.

@stale stale bot added the stale No recent activity on this issue label Jan 20, 2023
@yantosca yantosca added never stale Never label this issue as stale and removed stale No recent activity on this issue labels Jan 23, 2023
@msulprizio
Copy link
Contributor

Sorry for the late reply @viral211. We fixed this issue in 14.1.0 (in the benchmark review stages now). See geoschem/geos-chem#1321 and the fix at geoschem/geos-chem#1595.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category: Bug Something isn't working never stale Never label this issue as stale topic: Configuration Files Related to HEMCO configuration files topic: Input Data Related to input/emissions data, or disk read/write operations
Projects
None yet
Development

No branches or pull requests

3 participants