Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix GCHPctmEnv small numerical bugs #456

Open
wants to merge 4 commits into
base: dev/no-diff-to-benchmark
Choose a base branch
from
Open

Fix GCHPctmEnv small numerical bugs #456

wants to merge 4 commits into from

Conversation

yuanjianz
Copy link

@yuanjianz yuanjianz commented Oct 30, 2024 •
edited by lizziel
Loading

Name and Institution (Required)

Name: Yuanjian Zhang
Institution: WashU

Describe the update

  1. Correct dry mass flux derivation.
  2. Correct upwardsMassflux sign.

Expected changes

  1. Dry mass flux will be slightly smaller than before but is expected.
  2. UpwardsMassflux diagnostic will correctly be positive = "up"

Related Github Issue

closes #445
closes #455

@lizziel
Copy link
Contributor

lizziel commented Nov 12, 2024

Update #1 affects only GCHP runs that import mass fluxes from offline meteorology which makes this a zero diff update for benchmarking. I will therefore put milestone 14.5.1.

@lizziel lizziel added this to the 14.5.1 milestone Nov 12, 2024
@lizziel lizziel added topic: Runtime Related to runtime issues (e.g. simulation stops with error) category: Bug Fix Fixes a previously-reported issue topic: Diagnostics Related to output diagnostic data labels Nov 12, 2024
@yuanjianz yuanjianz force-pushed the bugfix/gchp-advection-small-numerical-bugs branch from bf79029 to 4023750 Compare November 15, 2024 17:40
@lizziel lizziel changed the base branch from main to dev/no-diff-to-benchmark November 15, 2024 19:11
@lizziel lizziel self-requested a review November 15, 2024 19:12
lizziel
lizziel requested changes Nov 15, 2024
View reviewed changes
Copy link
Contributor

@lizziel lizziel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also update the changelog with the updates.

src/GCHP_GridComp/GCHPctmEnv_GridComp/GCHPctmEnv_GridCompMod.F90 Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lizziel lizziel Awaiting requested review from lizziel

Assignees
No one assigned
Labels
category: Bug Fix Fixes a previously-reported issue topic: Diagnostics Related to output diagnostic data topic: Runtime Related to runtime issues (e.g. simulation stops with error)
Projects
None yet
Milestone
14.5.1
Development

Successfully merging this pull request may close these issues.

Opposite sign of UpwardsMassflux diagnostic GCHP mass flux wrong moisture correction
2 participants
@yuanjianz @lizziel