Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

geonetwork-microservices - georchestra integration & divergences #3931

Open
pmauduit opened this issue Apr 6, 2023 · 7 comments
Open

geonetwork-microservices - georchestra integration & divergences #3931

pmauduit opened this issue Apr 6, 2023 · 7 comments

Comments

@pmauduit
Copy link
Member

pmauduit commented Apr 6, 2023

codebase

As of today, we have a fork of the geonetwork/geonetwork-microservices repository:
https://github.com/georchestra/geonetwork-microservices

The default branch is geor-main, but it is unclear why it diverges from upstream/main.

CICD

  • buildbot-side, there is a buildjob-geonetwork-microservices job, which packages the searching and ogc-api-records webservice, tracking the geor-main branch.
  • GHA-side, we have one job specification, where only the searching microservice is being built.
  • On the geor-main-2301 branch, the build is modified so that searching is no longer built, but ogc-api-records is.

configuration

Issues

It is unclear what we do want to do with the geonetwork-microservices project into georchestra:

  • What do we want to integrate ? searching ? ogc-api-records ? both ?
  • which branch should be built ?
  • is a fork still necessary ?

The main argument for keeping a fork is that we can control the version of the dependencies, e.g. making sure that we can build microservices which are compatible with the ES version being used in the geonetwork fork for geOrchestra.

@pmauduit pmauduit added this to the 23.0.0 milestone Apr 6, 2023
@landryb
Copy link
Member

landryb commented Apr 6, 2023

@pmauduit
Copy link
Member Author

pmauduit commented Apr 6, 2023

It is worth a try ...

@pmauduit
Copy link
Member Author

pmauduit commented Apr 6, 2023

We also should cleanup branches of the repository to make it clear which one is the relevant one.

@fvanderbiest
Copy link
Member

Postponing to a 23.1 release ...

@pmauduit pmauduit modified the milestones: 23.0.0, 23.1.0 Apr 21, 2023
@pmauduit
Copy link
Member Author

  • buildbot-side, there is a buildjob-geonetwork-microservices job, which packages the searching and ogc-api-records webservice, tracking the geor-main branch.

We don't generate debian packages yet, do we ? If so we might also want it to provide a systemd service file.

@landryb
Copy link
Member

landryb commented Apr 21, 2023

i don't think there's the plumbing to generate debian packages for geonetwork microservices, but that'd be a nice addition indeed ! the systemd service files already exist in the ansible repo iirc

@pmauduit
Copy link
Member Author

Also, the debian maven plugin we are using seems a bit outdated (last release on 2013): https://debian-maven.sourceforge.net/index.html
But someone forked it and there are some recent activites on it: https://fracpete.github.io/debian-maven-plugin/usage.html

In any of their respective documentations I could find anything related to packaging a systemd service though, but it is probably doable with a service file + a post-hook to daemon-reload systemd + starting the service.

@fvanderbiest fvanderbiest removed this from the 24.0.0 milestone Jun 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants