feat(libs): Focus search field on app load #677

Angi-Kinas · 2023-11-08T09:59:15Z

Add manual change detection as described here

github-actions · 2023-11-08T10:00:24Z

Affected libs: feature-search, feature-router, feature-map, feature-dataviz, feature-record, ui-inputs, feature-editor, ui-elements, feature-catalog, ui-catalog, ui-search,
Affected apps: datahub, metadata-editor, demo, webcomponents, search, map-viewer, metadata-converter, datafeeder,

🚀 Build and deploy storybook and demo on GitHub Pages
📦 Build and push affected docker images

jahow

Thanks! It looks like you unintentionally removed the line that was doing the focus, but I tested with the line re-added and it works well. Also I think this behavior should be configurable and disabled by default, otherwise it might disrupt the experience in other contexts e.g. the web component or the map viewer.

jahow · 2023-11-09T08:41:45Z

libs/ui/inputs/src/lib/autocomplete/autocomplete.component.ts

@@ -109,6 +109,7 @@ export class AutocompleteComponent
  }

  ngAfterViewInit(): void {
+    this.inputRef.nativeElement.focus()


I think you removed this line in the other commit, but you still need it otherwise the field is not focused

coveralls · 2023-11-09T09:03:11Z

coverage: 81.939% (-4.7%) from 86.617%
when pulling f360092 on DH-focus-search-field-on-app-load
into 5f1c197 on main.

and resolve expression has changed after it was checked - error see here: https://angular.io/errors/NG0100 and make focus configurable and diasbled by default

jahow

Great, thanks!

jahow reviewed Nov 9, 2023

View reviewed changes

Angi-Kinas force-pushed the DH-focus-search-field-on-app-load branch from b5abf7d to 95d5b8c Compare November 9, 2023 09:01

Angi-Kinas force-pushed the DH-focus-search-field-on-app-load branch from 95d5b8c to 9d57305 Compare November 9, 2023 09:03

feat(libs): Add focus on search field ...

f360092

and resolve expression has changed after it was checked - error see here: https://angular.io/errors/NG0100 and make focus configurable and diasbled by default

Angi-Kinas force-pushed the DH-focus-search-field-on-app-load branch from 9d57305 to f360092 Compare November 9, 2023 10:27

jahow approved these changes Nov 9, 2023

View reviewed changes

Angi-Kinas merged commit 1c1919e into main Nov 13, 2023
7 checks passed

Angi-Kinas deleted the DH-focus-search-field-on-app-load branch November 13, 2023 07:40

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(libs): Focus search field on app load #677

feat(libs): Focus search field on app load #677

Angi-Kinas commented Nov 8, 2023 •

edited

Loading

github-actions bot commented Nov 8, 2023 •

edited

Loading

jahow left a comment

jahow Nov 9, 2023

coveralls commented Nov 9, 2023 •

edited

Loading

jahow left a comment

feat(libs): Focus search field on app load #677

feat(libs): Focus search field on app load #677

Conversation

Angi-Kinas commented Nov 8, 2023 • edited Loading

github-actions bot commented Nov 8, 2023 • edited Loading

jahow left a comment

Choose a reason for hiding this comment

jahow Nov 9, 2023

Choose a reason for hiding this comment

coveralls commented Nov 9, 2023 • edited Loading

jahow left a comment

Choose a reason for hiding this comment

Angi-Kinas commented Nov 8, 2023 •

edited

Loading

github-actions bot commented Nov 8, 2023 •

edited

Loading

coveralls commented Nov 9, 2023 •

edited

Loading