-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Datahub: Fix abstract display in record preview #672
Conversation
Affected libs:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is taking the stripHtml
function too far. Keeping whitespace and at the very least line breaks can be considered a feature, although I'm not sure if it would break anything.
Maybe adding another util removeWhitespace
would make sense? And then the two can be combined for the results abstract.
since it can break line-clamp behaviour
ba55fbf
to
8875d8e
Compare
Good point, I completely agree (although the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot @tkohr, even though it works exactly like before I believe you still improved the readability for future contributors ;)
since it can break line-clamp behaviour Backport from #672
backported in a230b2c |
Remove unnecessary whitespaces from html which can break line-clamp behaviour. Example abstract. Has only been reproduced on firefox.