-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WebComponents / fix dropdown-selector not showing #658
Conversation
Affected libs:
|
This will work with any webcomponent by creating an overlay at the root of each webcomponent Changed the name of the custom OverlayContainer for clarity
this will make icons and fonts appear in web components
037fd7f
to
ba50d70
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the various fixes @jahow !
Just noticed that the dropdown does not close when clicking the select box itself.
libs/ui/inputs/src/lib/dropdown-multiselect/dropdown-multiselect.component.html
Show resolved
Hide resolved
…kdrop This makes the overlay correctly close with WC as well
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @jahow, working very smoothly now!
This PR brings several fixes to the web components:
@font-face
definitions to the host document; this is necessary because@font-face
rules in ShadowDOM will not trigger the download of the font, thus icons will never show in web components without that