-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: Thumbnail multiple images fallback when 404 #570
Conversation
Affected libs:
|
need to get rid of this multiple fit and fits inputs. find a better way to implement it
… org log returns 404
4dcb967
to
a947f19
Compare
Thanks @Angi-Kinas for this nice feature ! It's just a proposition : It may be cleaner if html files doesn't handles arrays. Instead of Coverage has barely decreased. Covering the existing getter should work for re-increasing it. I've let some comments. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work! adapted it to keep the existing UI to work and it's all good :)
For the Thumbnail image we want to display (with priority):
The bug exists because there is a thumbnail image but it returns a 404. In this case we should show the org logo. If the org logo also return a 404 it should show the placeholder. This is fixed in this PR.