Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

version 1.0.0 #84

Merged
merged 37 commits into from
Nov 8, 2023
Merged

version 1.0.0 #84

merged 37 commits into from
Nov 8, 2023

Conversation

cole-brokamp
Copy link
Member

@cole-brokamp cole-brokamp commented Oct 12, 2023 •
edited
Loading

  • greatly simplify dependencies to make it easier for data consumers to install and use the package
    • rely on {fr} version 0.2.0; remove all attribute-related metadata functions
    • use vroom directly instead of readr
  • simplified webpage (no articles); shortened and clarified CoDEC specs vignette
  • data updates
    • make drivetime standalone by not relying on separate repository
    • deprecate drivetime resository
    • added crime risk data
    • update all scripts to use fr_* helper functions in {fr} version 0.3.0
  • check_*() functions take a tibble or list, in addition to a fr_tdr object
  • move fr_tdr-specific interpolation here from {cincy}
    • one function that can dissassociate d/md, merge geography, interpolate, as_fr_tdr(.template)
    • add back geography argument for codec_data()
  • move shiny app here
    • reimplement data for app as in this package
    • use new interpolation function here to carry metadata through

@cole-brokamp cole-brokamp marked this pull request as draft October 12, 2023 20:44
This was linked to issues Oct 12, 2023
check_codec fails to find where metadata is present without a corresponding column of data #83
Closed
separate tabular data resource functions into separate package #75
Closed
@cole-brokamp cole-brokamp changed the title Use fr package for all tabular data resource code version 1.0.0 Oct 17, 2023
@cole-brokamp cole-brokamp self-assigned this Oct 18, 2023
@cole-brokamp cole-brokamp marked this pull request as ready for review November 6, 2023 22:40
@cole-brokamp cole-brokamp merged commit b77958e into main Nov 8, 2023
5 checks passed
@cole-brokamp cole-brokamp deleted the use-fr branch November 8, 2023 22:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@erikarasnick erikarasnick erikarasnick approved these changes

@andrew-vancil andrew-vancil Awaiting requested review from andrew-vancil

Assignees

@cole-brokamp cole-brokamp

Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@cole-brokamp @erikarasnick @andrew-vancil