Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release builds broken with Rust 1.82 #833

Closed
gadomski opened this issue Oct 18, 2024 · 2 comments
Closed

Release builds broken with Rust 1.82 #833

gadomski opened this issue Oct 18, 2024 · 2 comments

Comments

@gadomski
Copy link
Contributor

At 0b6715c:

$ RUSTFLAGS=-Awarnings rustup run 1.81 cargo build --release --quiet
$ RUSTFLAGS=-Awarnings rustup run 1.82 cargo build --quiet
$ RUSTFLAGS=-Awarnings rustup run 1.82 cargo build --release --quiet
error[E0275]: overflow evaluating the requirement `<G as geo_traits::geometry::GeometryTrait>::GeometryCollection<'_>: geo_traits::geometry_collection::GeometryCollectionTrait`
    |
    = help: consider increasing the recursion limit by adding a `#![recursion_limit = "256"]` attribute to your crate (`geoarrow`)
note: required for `GeometryCollectionIterator<'_, f64, <<<... as GeometryCollectionTrait>::ItemType<'_> as GeometryTrait>::GeometryCollection<'_> as GeometryCollectionTrait>::ItemType<'_>, ...>` to implement `Iterator`
   --> src/geo_traits/iterator.rs:39:15
    |
37  |                   ItemType: 'a + $item_trait<T = T>,
    |                                              ----- unsatisfied trait bound introduced here
38  |                   G: $self_trait<T = T, ItemType<'a> = ItemType>,
39  |               > Iterator for $struct_name<'a, T, ItemType, G>
    |                 ^^^^^^^^     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
...
109 | / impl_iterator!(
110 | |     GeometryCollectionIterator,
111 | |     GeometryCollectionTrait,
112 | |     GeometryTrait,
113 | |     geometry_unchecked
114 | | );
    | |_- in this macro invocation
    = note: required for `GeometryCollectionIterator<'_, f64, <<<... as GeometryCollectionTrait>::ItemType<'_> as GeometryTrait>::GeometryCollection<'_> as GeometryCollectionTrait>::ItemType<'_>, ...>` to implement `IntoIterator`
    = note: the full name for the type has been written to '/Users/gadomski/Code/geoarrow/geoarrow-rs/target/release/deps/geoarrow-d23c01f6fb33c633.long-type-12907003299254778690.txt'
    = note: consider using `--verbose` to print the full type name to the console
    = note: the full name for the type has been written to '/Users/gadomski/Code/geoarrow/geoarrow-rs/target/release/deps/geoarrow-d23c01f6fb33c633.long-type-12907003299254778690.txt'
    = note: consider using `--verbose` to print the full type name to the console
    = note: this error originates in the macro `impl_iterator` (in Nightly builds, run with -Z macro-backtrace for more info)

For more information about this error, try `rustc --explain E0275`.
error: could not compile `geoarrow` (lib) due to 1 previous error

I tried their suggestion of a 256 recursion limit and it just escalated to

help: consider increasing the recursion limit by adding a `#![recursion_limit = "512"]` attribute to your crate (`geoarrow`)

so 🤷🏼

@kylebarron
Copy link
Member

This is a duplicate of #716

@kylebarron kylebarron closed this as not planned Won't fix, can't repro, duplicate, stale Oct 18, 2024
@kylebarron
Copy link
Member

@gadomski FWIW you can still compile with

RUSTFLAGS='-Zinline-mir=no' rustup run nightly cargo build --release

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants