Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

root/unknown annotations are not displayed #58

Open
krchristie opened this issue Oct 21, 2024 · 4 comments
Open

root/unknown annotations are not displayed #58

krchristie opened this issue Oct 21, 2024 · 4 comments
Assignees
Labels
bug Something isn't working high priority

Comments

@krchristie
Copy link

@LiNiMGI noticed that "unknown" annotations to the root nodes are not being displayed and thus cannot be deleted or edited.

I can replicate this. Here is our example for mouse Lichi, which only has three annotations, all to root nodes:

Here is the view in the Graph Editor:
2024_10_21-unknowns-GE

Here is the view in the Form:
2024_10_21-unknowns-Form

Here is the view in the Standard Annotations editor: which indicates that there are three annotations but does not display any of them:
2024_10_21-unknowns-Standard

@vanaukenk
Copy link

Thanks for reporting this @krchristie @LiNiMGI

I can reproduce what you see for the mouse gene above, but the weird thing is that it's not happening for me for new entries; they're being displayed properly.

I'll have to dig into this with @tmushayahama

@vanaukenk
Copy link

The issue here is a difference between how the standard annotation form is expecting root CC annotations to be expressed vs how they actually are expressed for existing root CC annotations.

@tmushayahama will update the standard annotation editor to simply state 'gp 'is active in' root CC' and I'll test on noctua-dev.

@tmushayahama tmushayahama mentioned this issue Nov 4, 2024
@vanaukenk
Copy link

I've tested this on noctua-dev by checking existing models:

MGI Lichi
SGD Msc7
ZFIN cyp4v2b
MGI Wdr35

and also created three new C. elegans root node annotations.

All the annotations seem to be displayed and/or created properly.

@krchristie @LiNiMGI - please also take a look to make sure it's fixed for you, too. Thank you!

@vanaukenk vanaukenk moved this from In Progress to Testing - noctua-dev in Noctua form refactor concealing GO-CAM model Nov 14, 2024
@LiNiMGI
Copy link

LiNiMGI commented Nov 15, 2024

checked a couple MGI genes, yes, it's fixed in noctua-dev, thanks @vanaukenk

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working high priority
Projects
Development

No branches or pull requests

4 participants