-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add action to check conformance with "GPAD ShEx" on each change #544
Comments
I've created a preliminary implementation of the ShEx checking part of this, which runs whenever a model is saved. It was a bit too slow using the shex-java library already used in Minerva, so I updated our Jena dependency to a version that comes with its own ShEx functionality (this is what I've been using to test the gpad-shapes schema on the command line). With that checker, performance seems reasonable. For a model on the larger side (http://noctua.geneontology.org/editor/graph/gomodel:MGI_MGI_88276) it adds about 2.5 seconds to the save time, but for a smaller model (http://noctua.geneontology.org/editor/graph/gomodel:YeastPathways_PWY3O-4105) it's much faster, 135 ms. Next I'll add writing the conformance result into the model and then add this to |
I made a PR in #546. I also put the changes on the |
@kltm hang on; need to deal with some test problems. |
@kltm the
These files are currently on a branch in go-shapes: |
@balhoff Does this include a "surfacing" of the data (coming out in the API responses), or is this just adding the metadata to models on change? |
Both—the surfacing seemed to happen without any specific effort on my part. |
On noctua-dev, as a manual one-off on
|
@kltm @tmushayahama I updated the PR and dev branch so that the property comes out as |
From 2024-07-25 workbenches call: @balhoff |
@vanaukenk @tmushayahama I've added the conformance value to the search API output. |
The latest |
I've tested this with a small model:
Seems to be working okay. |
Need to check performance of this on various-sized models.
The text was updated successfully, but these errors were encountered: