Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not show input/output relationship edges when other regulation edges exist #29

Open
pkalita-lbl opened this issue Nov 13, 2024 · 0 comments

Comments

@pkalita-lbl
Copy link
Contributor

Currently the CX2 files we produce faithfully add edges for all types of relationships between activities. This means that we may end up showing "unnecessary" edges. For example, if there is already a "directly positively regulates" edge between two activities, then the "has input" relationship is somewhat implicit and doesn't necessarily need to be drawn -- even though that's what the GO-CAM technically says.

Here is an example on NDEx that shows this behavior:

Image

The pathway visualization widget has some logic to collapse the "has input" (blue) edges, so it ends up looking like this:

Image

The task here is to do a little rooting around in the pathway visualization widget codebase and see if we can reproduce its logic in the CX2 conversion code.

@pkalita-lbl pkalita-lbl converted this from a draft issue Nov 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

No branches or pull requests

1 participant