Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Want to look into merging my fork? #9

Open
nmoschkin opened this issue May 2, 2021 · 0 comments
Open

Want to look into merging my fork? #9

nmoschkin opened this issue May 2, 2021 · 0 comments

Comments

@nmoschkin
Copy link

I have made some really heavy, insane changes to the FancyCandles (I only pulled it around 2 months ago), adding a lot of new features including a running real-time value to display in the cross price value field when the mouse is not over, several visual improvements (a redesigned scroll bar), and other extras including number formatting, dash patterns for cross lines, a sub-heading for legend, etc.

Now, I have seen that you have also added a lot of new cool features to your own version, and I want to see if they're mergeable.

I'm looking through some of your code, now.

So, for all the improvements that I've made, there will need to be a settings area added in the settings window, now, I guess.

Not too sure how to merge your changes into my code.

Oh, another very major thing I did is that I converted the entire project to .NET 5.

Since there's a lot of ground that separates the two versions, I was wondering if you wanted to discuss merging, some time?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant