Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2024.10.0: test suite is packaged into .whl archive #1731

Open
kloczek opened this issue Oct 21, 2024 · 2 comments
Open

2024.10.0: test suite is packaged into .whl archive #1731

kloczek opened this issue Oct 21, 2024 · 2 comments

Comments

@kloczek
Copy link

kloczek commented Oct 21, 2024

$ unzip -l fsspec-2024.10.0-py3-none-any.whl | grep tests
    10046  02-02-2020 00:00   fsspec/tests/abstract/__init__.py
     4973  02-02-2020 00:00   fsspec/tests/abstract/common.py
    19967  02-02-2020 00:00   fsspec/tests/abstract/copy.py
    20755  02-02-2020 00:00   fsspec/tests/abstract/get.py
     1982  02-02-2020 00:00   fsspec/tests/abstract/mv.py
    21201  02-02-2020 00:00   fsspec/tests/abstract/put.py

Probably easiest way to solve that is to move fsspec/tests/ tests/.
Do you want me to submit PR for that? 🤔

@martindurant
Copy link
Member

It seems like these few files have missed the exclusion pattern. Does it pose a problem? We are talking a very few kB of files.

easiest way to solve that is to move fsspec/tests/ tests/

This does not match the package structure that is being followed throughout this stable of repos (and others from dask heritage).

@kloczek
Copy link
Author

kloczek commented Oct 21, 2024

Problem is that files which are part of the test suite and are not official part pf the module public interface should not be installed.
tests/ it is typical location of the test suite in +90% of the modules source trees.
This directory by is excluded on forming .whl and added into sdist tar ball.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants