You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I've been tracking down all the evidence ("leads") for the BND calls that are made and it seems that evidence from supplementary alignments sometimes gets omited. This happens in the classification method sniffles.sv.classify_splits in line 585 (or thereabouts):
elifqry_dist_abs<maxsvlen_other:
## BND#
Perhaps I'm misunderstanding something but in a BND I don't see how qry_dist_abs implies anything about the "size" of the SV, and therefore I don't understand why the rest should be subject to that condition (the same condition makes total sense for an INV, and it is indeed applied there). So I think that the right thing to do would be to change the elif ... to an else.
I'm raising the issue here to see if there's a reason I'm not thinking about, or a test that I should perform prior to submitting the PR.
Thanks!
The text was updated successfully, but these errors were encountered:
I've been tracking down all the evidence ("leads") for the BND calls that are made and it seems that evidence from supplementary alignments sometimes gets omited. This happens in the classification method
sniffles.sv.classify_splits
in line 585 (or thereabouts):Perhaps I'm misunderstanding something but in a BND I don't see how
qry_dist_abs
implies anything about the "size" of the SV, and therefore I don't understand why the rest should be subject to that condition (the same condition makes total sense for an INV, and it is indeed applied there). So I think that the right thing to do would be to change theelif ...
to anelse
.I'm raising the issue here to see if there's a reason I'm not thinking about, or a test that I should perform prior to submitting the PR.
Thanks!
The text was updated successfully, but these errors were encountered: