Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: BND evidence from supplementary alignements discarded (sometimes) #513

Open
yfarjoun opened this issue Oct 23, 2024 · 0 comments
Open

Comments

@yfarjoun
Copy link
Contributor

I've been tracking down all the evidence ("leads") for the BND calls that are made and it seems that evidence from supplementary alignments sometimes gets omited. This happens in the classification method sniffles.sv.classify_splits in line 585 (or thereabouts):

        elif qry_dist_abs < maxsvlen_other:
            #
            # BND
            #

Perhaps I'm misunderstanding something but in a BND I don't see how qry_dist_abs implies anything about the "size" of the SV, and therefore I don't understand why the rest should be subject to that condition (the same condition makes total sense for an INV, and it is indeed applied there). So I think that the right thing to do would be to change the elif ... to an else.

I'm raising the issue here to see if there's a reason I'm not thinking about, or a test that I should perform prior to submitting the PR.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant