Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parse hostname from /proc/sys/kernel/hostname for Unix #660

Open
DissectBot opened this issue Apr 3, 2024 · 1 comment · May be fixed by #704
Open

Parse hostname from /proc/sys/kernel/hostname for Unix #660

DissectBot opened this issue Apr 3, 2024 · 1 comment · May be fixed by #704
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@DissectBot
Copy link

DissectBot commented Apr 3, 2024

Sometimes we have /proc available (local targets or acquires with proc collected). We should add /proc/sys/kernel/hostname to the path of files to check for the hostname for Unix targets.

def _parse_hostname_string(self, paths: Optional[list[str]] = None) -> Optional[dict[str, str]]:
(https://github.com/fox-it/dissect.target/blob/a314d250f7e1b40adc841fb526cb5bd32de6159d/dissect/target/plugins/os/unix/_os.py#L144|smart-link)

@DissectBot DissectBot added the good first issue Good for newcomers label Apr 3, 2024
@Schamper Schamper added the enhancement New feature or request label Apr 3, 2024
@CinisSec
Copy link

Tried to implement this with following pull request #704

@Miauwkeru Miauwkeru linked a pull request May 14, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants