Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong output of registry values of type REG_MULTI_SZ #1786

Open
gabrielg5 opened this issue Aug 6, 2024 · 0 comments
Open

Wrong output of registry values of type REG_MULTI_SZ #1786

gabrielg5 opened this issue Aug 6, 2024 · 0 comments

Comments

@gabrielg5
Copy link
Collaborator

gabrielg5 commented Aug 6, 2024

Configuration

impacket version: v0.12.0.dev1
Python version: N/A
Target OS: Windows

If triggering reg.py query example and showing a multi string value, it is shown in a wrong format; all strings together in the same line without any separator
This has been checked while working on #1785

Debug Output With Command String

┌──(xxx㉿XXX)-[~/impacket/examples]
└─$ python reg.py <domain>/<user>@<ip> query -keyName "HKLM\SOFTWARE\test"
Impacket v0.12.0.dev1+20240806.130108.73faf185 - Copyright 2023 Fortra

Password:
HKLM\SOFTWARE\test
        number1 REG_DWORD        0x1
        number2 REG_DWORD        0x1
        number3  REG_DWORD        0x0
        thenumber   REG_DWORD        0x2
        multistring   REG_MULTI_SZ     firstsecondwith spaces

In the context of #1785, when triggering reg.py add it has been implemented a format for showing multi string values.

┌──(xxx㉿XXX)-[~/impacket/examples]
└─$ python reg.py <domain>/<user>@<ip> add -keyName "HKLM\SOFTWARE\test" -v "multi" -vd "first" -vd second -vd "with spaces" -vt REG_MULTI_SZ
Impacket v0.12.0.dev1+20240806.130906.2571ce44 - Copyright 2023 Fortra

Password:
Successfully set
        key     HKLM\SOFTWARE\test\multi
        type    REG_MULTI_SZ
        value   first
                second
                with spaces
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant