Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: cancel trigger.dev job on unassign #148

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: cancel trigger.dev job on unassign #148

wants to merge 1 commit into from

Conversation

Abhi-Bohora
Copy link

@Abhi-Bohora Abhi-Bohora commented Nov 2, 2024 •
edited
Loading

What does this PR do?

Fixes: #146
When the user was /unassign from the issue the task will still be running on the trigger.dev. This pr aims to fix that by cancelling the running task after the issue is /unassign

2024-11-02.13-38-04.online-video-cutter.com.mp4

Fixes # (issue)

How should this be tested?

  • Test A
  • Test B

Checklist

Required

  • Filled out the "How to test" section in this PR
  • Read How we Code at oss.gg
  • Self-reviewed my own code
  • Commented on my code in hard-to-understand bits
  • Ran pnpm build
  • Checked for warnings, there are none
  • Removed all console.logs
  • Merged the latest changes from main onto my branch with git pull origin main
  • My changes don't cause any responsiveness issues

Appreciated

  • If a UI change was made: Added a screen recording or screenshots to this PR
  • Updated the Formbricks Docs if changes were necessary

@vercel Vercel
Copy link

vercel bot commented Nov 2, 2024

@Abhi-Bohora is attempting to deploy a commit to the formbricks Team on Vercel.

A member of the Team first needs to authorize it.

@github-actions github-actions bot added the bug Something isn't working label Nov 2, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 2, 2024 •
edited
Loading

Thank you for following the naming conventions for pull request titles! 🙏

@Abhi-Bohora Abhi-Bohora changed the title fix:Cancel trigger.dev job on unassign fix: cancel trigger.dev job on unassign Nov 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] Cancel trigger.dev job on unassign
1 participant
@Abhi-Bohora