Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Streamline svg icons / Some svg flag icons are broken #17

Open
josefglatz opened this issue Feb 14, 2017 · 4 comments
Open

Streamline svg icons / Some svg flag icons are broken #17

josefglatz opened this issue Feb 14, 2017 · 4 comments

Comments

@josefglatz
Copy link

I can agree with TYPO3/TYPO3.Icons#282, that some svg icons needs a viewBox to not break in some browsers.

Instead of duplicating the issue, I just reference it, is it is already explained in detail:
TYPO3/TYPO3.Icons#282
TYPO3/TYPO3.Icons#283

@behnam
Copy link
Collaborator

behnam commented Feb 14, 2017

The files are auto-downloaded from Wikipedia (Wikimedia Commons). That said, we can fix the source by uploading a fixed version.

Is it one problem (missing viewBox) or also other issues? Do you have a script for the fix?

@josefglatz
Copy link
Author

Hi, thx for your fast response.
Ah I see. Do you suggest to fix it at wikipedia or in your repo? Actually I have no script for the fix.

@behnam
Copy link
Collaborator

behnam commented Feb 14, 2017

We don't maintain a local source for the files, so, if only fixed here in the repo, it would get overridden on the next update, or, if marked locally, then not getting upstream updates. So, I say we better fix the files on Wikipedia. (Also benefiting other users of the file.)

Do you know how many files are broken? If just a few, we can fix manually. If more, better to have a script.

@josefglatz
Copy link
Author

I try to take care of it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants