Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Running Pluto with Malt.jl inside CI tests does not update code coverage #2818

Open
disberd opened this issue Feb 19, 2024 · 2 comments · May be fixed by #2822
Open

Running Pluto with Malt.jl inside CI tests does not update code coverage #2818

disberd opened this issue Feb 19, 2024 · 2 comments · May be fixed by #2822

Comments

@disberd
Copy link
Contributor

disberd commented Feb 19, 2024

This is not a direct issue to Pluto itself, but I thought it would be good to mention it in case someone else experience this.

I am running non-interactive Pluto sessions as part of CI tests in https://github.com/disberd/PlutoDevMacros.jl

After a while not submitting a PR anymore, I noticed a couple days ago that for my new PR, all of the parts of code only tested via the Pluto session did not appear as covered anymore despite being so in the previous CI run (a few months back).

Today as part of another PR I did think it could be related to recent versions of Pluto defaulting to Malt.jl rather than Distributed to run notebook code.

This commit simply set the flag to use distributed instead of Malt and indeed my code coverage went back up to around 95% correctly considering all of the code being only tested as part of a non-interactive Pluto session.

Just leaving this here in case someone else does run Pluto sessions as part of testing and saw the CI coverage drop.
@disberd disberd changed the title Running Pluto inside Package tests does not increase code coverage with Malt.jl Running Pluto with Malt.jl inside CI tests does not update code coverage Feb 19, 2024
@fonsp
Copy link
Owner

fonsp commented Feb 21, 2024

Thanks! This is an intentional difference between Malt and Distributed: Malt does not inherit the command line flags of the parent process, including --code-coverage. Feel free to make a PR like #2774 to allow setting the code coverage flag of worker processes. I think it would be nice if PlutoDevMacros could use Malt

@disberd
Copy link
Contributor Author

disberd commented Feb 21, 2024

I didn't realize this was a julia flag :D. Thanks I'll make a PR

@disberd disberd linked a pull request Feb 21, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add Compiler flag to specify --code-coverage disberd/Pluto.jl
2 participants
@fonsp @disberd