Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Report when Relationship TargetDAOKey not found #1910

Open
jlhughes opened this issue Feb 16, 2019 · 1 comment
Open

Report when Relationship TargetDAOKey not found #1910

jlhughes opened this issue Feb 16, 2019 · 1 comment
Assignees
@jlhughes @minsunny

Comments

@jlhughes
Copy link
Collaborator

The Relationship TargeDAOKey, when not explicitly specified, is calculated based on the target property. If this is incorrect, then a NullPointerException is generated when the missing TargetDAO is referenced. We know when this occurs so add reporting/logging.
@jlhughes jlhughes self-assigned this Feb 16, 2019
@kgrgreer
Copy link
Collaborator

The following commit adds one check, but there are several other places that need similar support:

commit 4124b06 (HEAD -> master, origin/master, origin/HEAD)
Author: Kevin Greer [email protected]
Date: Fri Feb 22 10:58:00 2019 -0500

Add assert that targetDAOKey is present.

@minsunny minsunny mentioned this issue Feb 26, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jlhughes jlhughes

@minsunny minsunny

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@jlhughes @kgrgreer @minsunny